Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement validator set historical queries #119

Closed
maurolacy opened this issue Aug 31, 2023 · 0 comments · Fixed by #122
Closed

Implement validator set historical queries #119

maurolacy opened this issue Aug 31, 2023 · 0 comments · Fixed by #122
Assignees

Comments

@maurolacy
Copy link
Collaborator

maurolacy commented Aug 31, 2023

Implement historical valset data on the Provider. So that we can check for validator pubkey at the misbehaviour height.

This can be done through an SnapshotMap or IndexedShapshotMap.
Alternatively, it can be done through a conventional Map or IndexedMap, with composite (validator, height) keys, for flexibility and maintenance (pruning of older keys).

Note: This may be difficult to do with the current impl, as the valset updates use CRDT for consistency over unordered channels.
Let's consider changing this into a SnapshotMap or composite key Map, relaxing consistency and order guarantees in the pursuit of functionality: historical, queryable data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant