Find motorway_link with missing oneway tags

[planemad]

The recent OSRM update Project-OSRM/osrm-backend#2491 does not automatically consider every motorway_link as oneway anymore.

Motorway links with missing oneway tags in OSM may now create incorrect routes. We need a linter to detect such links so that mappers can add the oneway=yes if required.

Sketch

• Find ways tagged highway=motorway_link without oneway tag
• If the link is connected to a highway=motorway with a oneway, it might also be a oneway

We can load these into to-fix for later review.

cc @Rub21

[Rub21]

@planemad can you check on the detection http://osmlab.github.io/to-fix/#/stats/missingonewaysmotorwaylink
also the validator https://github.com/osmlab/osmlint/tree/missingoneway/validators/missingOneway.

[planemad]

@Rub21 looking fantastic! Most of the incorrect detections are two way links connected to other one way links. These can be dropped.

False positives - Not an error

• Links between two motorways https://www.openstreetmap.org/way/248995749
• Links with access=no
  
• Link connected to another oneway link https://www.openstreetmap.org/way/21288171
  
  
  
  
  
  

[Rub21]

@planemad I've fixed the code to avoid false positive, could you check http://osmlab.github.io/to-fix/#/task/missingonewaysmotorwaylink ?

[Rub21]

@planemad ^^

[planemad]

@Rub21 sorry, missed this. Results look excellent, error rate is 1 in 10.

False positives:

• https://www.openstreetmap.org/way/421273035

I think the task is ready to hit, if you can fix ^ even better.

cc @maning @Andygol

[Rub21]

I think the task is ready to hit

Nice!

Next action:

• @Rub21 add missingOneway validator in connectivity linting. This will detect every two days.
• @planemad create a master ticket to start working on these issues.

[Rub21]

@planemad ^^

[Rub21]

@planemad still missing a master ticket to start working on this task - http://osmlab.github.io/to-fix/#/task/missingonewaysmotorwaylink, can you create it.?

[samely]

@planemad I've already created the master ticket, could you check out it?

[Rub21]

done!