Build script produces suspicious output

[AntiCompositeNumber]

I recently ran npm run build and committed the results as 7759f6c. This resulted in a number of suspicious changes:

7759f6c#diff-478a5b2128693e6e200c127873c89cd5231498ceca1ba5df34691011fb656d4eR5360-R5369

7759f6c#diff-642da3b5ef608466f0cd0aab2700409124f8e8d24123ad2a3cca8d68a6d64424R463-R492

7759f6c#diff-f756edc0aad0ee60103a32fd0c59be5b11e2b32214f2d5feda12d540495f0996R182-R197
etc.

It seems like the build script is somehow reverting the changes made in 6484e1c, but I have no idea why.

[AntiCompositeNumber]

It's not just that commit. It's also creating a phantom Migros Jet entry in brands/shop/supermarket from the one in

name-suggestion-index/data/brands/shop/convenience.json

Lines 3219 to 3229 in 09cedc3

	{
	"displayName": "Migros Jet",
	"id": "migrosjet-5b5772",
	"locationSet": {"include": ["tr"]},
	"tags": {
	"brand": "Migros Jet",
	"brand:wikidata": "Q1754510",
	"name": "Migros Jet",
	"shop": "convenience"
	}
	},

but without all the tags.

+    {
+      "displayName": "Migros Jet",
+      "id": "migrosjet-986a24",
+      "locationSet": {"include": ["001"]},
+      "tags": {
+        "brand": "Migros Jet",
+        "name": "Migros Jet",
+        "shop": "supermarket"
+      }
+    },

Very strange.

[AntiCompositeNumber]

I merged the non-suspicious build script output as de374e2.

[arch0345]

This is coming from nsi-collector, which collects the most common brands/operators from the OSM planet file (looks like this hasn't been updated in a while though). You can prevent these from being readded when running the build script by either adding it to matchNames for cases like Baltimore County or adding it to the exclude list at the beginning of each file. IIRC, adding it to the generic array will make the iD validator flag it as a suspicious name while adding it to the named array won't.

[AntiCompositeNumber]

Ah, that would do it, thanks. I didn't know that the collector merge was part of the build script.