Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make build_all_names gather names from craft=* too #3110

Closed
bhousel opened this issue Oct 13, 2019 · 3 comments
Closed

Make build_all_names gather names from craft=* too #3110

bhousel opened this issue Oct 13, 2019 · 3 comments
Assignees
Labels
enhancement Actionable - add an enhancement to the source code

Comments

@bhousel
Copy link
Member

bhousel commented Oct 13, 2019

The planet processing file isn't picking up anything under craft=* yet, so we might want to change the code to start doing this, so we can get accurate counts.

We're also starting to track some brands under leisure=*, healthcare=*, so may want to include them too.

Originally posted by @bhousel in #3096 (comment)

@bhousel bhousel added the enhancement Actionable - add an enhancement to the source code label Oct 13, 2019
@bhousel bhousel self-assigned this Oct 13, 2019
@tas50
Copy link
Contributor

tas50 commented Oct 13, 2019

I'm playing around with this right now and we probably want to avoid healthcare=* since we've moved those all over to the amenity tags in the index. We should keep all the amenity tags that are actually healthcare though. dentist, doctor, clinic, hospital, etc.

@bhousel
Copy link
Member Author

bhousel commented Oct 15, 2019

Thanks for taking this up and processing the planet files @tas50 👏

healthcare is an interesting one because we still keep the amenity tags around in the iD presets, and surely will for a while.

OSM-carto actually declined to render healthcare (see gravitystorm/openstreetmap-carto#3731) so a lot of people just don't use it.

@tas50
Copy link
Contributor

tas50 commented Oct 16, 2019

I filtered all this data and didn't really get anything back that was useful at this point. It just makes the whole planet processing take that much longer. I suspect not a lot of folks are using the craft tag and we'll have better luck driving its adoption through adding things to NSI vs. watching things hit 50+.

@tas50 tas50 closed this as completed Oct 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Actionable - add an enhancement to the source code
Projects
None yet
Development

No branches or pull requests

2 participants