-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Other suspicious MP cases #17
Comments
imho: we can use the I have created a minimal prototype script Check the reports about austria-latest.osm.pbf (2017-03-11T21:43:02Z)
berlin-latest.osm.pbf (2017-03-11T21:43:02Z)
asia-latest.osm.pbf (2017-03-09T21:43:02Z)
germany-latest.osm.pbf (2017-03-08T21:43:02Z)
see more ... : https://github.com/ImreSamu/osm_simple_relation_analyzer201703/blob/master/docs/index.md Example :FREQ: Analyze OSM Relations with role=outer without primary OSM keysaustria-latest.osm.pbf ( 2017-03-11T21:43:02Z ) http://download.geofabrik.de/europe/austria-updates [Rv:0.1b]
LIST of Problematic/OldStyle OSM Relations with role=outeraustria-latest.osm.pbf ( 2017-03-11T21:43:02Z ) http://download.geofabrik.de/europe/austria-updates [Rv:0.1b]
|
@nebulon42 Yes, I have thought about this and am tracking those, too, but haven't exposed the numbers on the stats page. There are currently about 140,000 multipolygon relations with a single member. I am not sure what to do about them, though. Many of them could probably be replaced by a simple closed way, but some of them will be too long for that, or it makes sense to keep the way as it is, because it is used in a neighboring multipolygon or so. Anyway, 140,000 multipolygons are not really that many so that the extra effort needed compared to a closed way would amount to a big problem. |
During the fixing of some intersections I left single object multipolygons. When it is a small building or something alike I converted it to a single way. In cases of larger landuses I kept the multipolygons, as the chance that additional inners will come up later is high and when everything else of similar style is a multipolygon it looks better. So in case you want to treat these as "to fix" I'd suggest to restrict it to small objects less than a hectare. |
@ImreSamu Just for information, I've fixed most of the issues in LIST_RELATION_NO_TYPE for Austria with exception of public transport, hiking routes and some weird stuff. |
Another case for cleanup are ways tagged with "type=multipolygon". There were about 100 cases in Austria, which I'm working on. Most are left overs and the tag can be deleted, but in some cases the mapper wanted to create an mp (and failed), so individual checking is necessary. |
A database query for relations with "type=multipolygon" and excluding tags ['landuse', 'natural', 'building', 'waterway', 'highway', 'leisure', 'amenity', 'boundary', 'railway', 'tourism', 'place', 'man_made', 'public_transport'] will yield 639 old-style or suspicious multipolygons in Austria (and all mps detected on the mp-map have already been fixed). Most of those are old-style buildings, landuses and boundarys. Update: turns out that with exception of buildings, these are really hard to fix. It's amazing what people have done with mps (and not all of it correctly, but often a better solution is not obvious or would require extensive changes). |
What about the current state of the comparison map: http://area.jochentopf.com/map/index.html#3/30.00/0.00 This morning it does not show any red dot. Are all relations fixed? |
@gscholz No, software error. Fixed now. |
Thanks, |
I'm not sure if you have this in your pipeline anyway, but found those cases worth mentioning here.
Multipolygon relations with only one member
Closed ways that are member of more than one multipolygon relation with role
outer
(clarified, that only closed ways that are member in more than one multipolygon with role outer may be suspicious)
The text was updated successfully, but these errors were encountered: