Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outline waterbodies #608

Closed
1ec5 opened this issue Dec 7, 2022 · 1 comment · Fixed by #610
Closed

Outline waterbodies #608

1ec5 opened this issue Dec 7, 2022 · 1 comment · Fixed by #610
Assignees

Comments

@1ec5
Copy link
Member

1ec5 commented Dec 7, 2022

This style currently gives bodies of water a relatively dark fill. On land, the water layer overpowers the land in areas with many lakes and streams, undercutting the illusion that the land is a layer atop the water (which is really just an illusion). At sea, the dark color contrasts too much with the boundaries of marine parks.

Panama

New Orleans

Fairfield

Print maps use a variety of blues for water. Maps aiming for a more rustic look tend to choose darker shades, but most choose lighter shades, probably to cut down on the cost of ink. A light fill almost always has a hairline stroke around the coastline or shoreline to give it more definition.

Rand McNally Hallwag California San Mateo County 2006 by Compass Maps

I think we should lighten the water fill and add a darker outline that matches the waterway line color. To keep seams in the water layer from appearing at the edges of harbors and along rivers, the line layer should be underneath the fill layer. I think a lighter color will make the marine parks look much less awkward and also dull the effect of faux knockout halos around place labels over sea (#606).

/ref gravitystorm/openstreetmap-carto#3895 gravitystorm/openstreetmap-carto#3896 gravitystorm/openstreetmap-carto#3926

@1ec5 1ec5 self-assigned this Dec 7, 2022
@ZeLonewolf
Copy link
Member

Can we get an estimate on how much we can expect to save on ink?

I can't remember why we made it so dark, but I suspect you'll find out shortly what the issue was 😂

@1ec5 1ec5 mentioned this issue Dec 9, 2022
@1ec5 1ec5 closed this as completed in #610 Dec 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants