From 7e93d11e15511029eb2bbd97a9a0e10c2ea1f1aa Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Lars=20G=C3=B6ttgens?= Date: Thu, 5 Dec 2024 23:56:12 +0100 Subject: [PATCH] Remove unneeded parent call method for `FPGroup` (#4347) --- src/Groups/GAPGroups.jl | 17 ----------------- 1 file changed, 17 deletions(-) diff --git a/src/Groups/GAPGroups.jl b/src/Groups/GAPGroups.jl index 2b26608d9a0..a17409309cc 100644 --- a/src/Groups/GAPGroups.jl +++ b/src/Groups/GAPGroups.jl @@ -2366,23 +2366,6 @@ function (G::FPGroup)(pairs::AbstractVector{Pair{T, S}}) where {T <: IntegerUnio return FPGroupElem(G, w) end -# This format is used in the serialization of `FPGroupElem`. -function (G::FPGroup)(extrep::AbstractVector{T}) where T <: IntegerUnion - famG = GAPWrap.ElementsFamily(GAPWrap.FamilyObj(GapObj(G))) - if GAP.Globals.IsFreeGroup(GapObj(G)) - w = GAPWrap.ObjByExtRep(famG, GapObj(extrep, true)) - else - # For quotients of free groups, `GAPWrap.ObjByExtRep` is not defined. - F = GAP.getbangproperty(famG, :freeGroup) - famF = GAPWrap.ElementsFamily(GAPWrap.FamilyObj(F)) - w1 = GAPWrap.ObjByExtRep(famF, GapObj(extrep, true)) - w = GAPWrap.ElementOfFpGroup(famG, w1) - end - - return FPGroupElem(G, w) -end - - function describe(G::FinGenAbGroup) l = elementary_divisors(G) length(l) == 0 && return "0" # trivial group