Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to flake8 6.x.x #1258

Closed
enikonovad opened this issue Nov 28, 2022 · 1 comment
Closed

Update to flake8 6.x.x #1258

enikonovad opened this issue Nov 28, 2022 · 1 comment
Assignees

Comments

@enikonovad
Copy link
Contributor

Issue description / feature objectives

Recently flake8 released a version 6.0.0 which seemed to drop the support of Python 3.7. The change broke flake8-broken-line plugin. As a result pre-commit autoupdate has been temporary disabled.

This issue is to track the changes to the flake8-broken-line and other plugins as they move to flake8 6.0.0+. Once the move have been completed pre-commit autoupdate should be enabled.

Caveats / Assumptions

Blocker to track: wemake-services/flake8-broken-line#281

Completion Criteria

Revert changes to makefile and enable pre-commit-update when either code-format, code-lint or mdformat is ran.

@degenaro
Copy link
Collaborator

degenaro commented May 6, 2024

in setup.cfg flake8 specification has no version restrictions, so the current is being used. In my python venv for the trestle develop branch using make develop:

flake8 --version
7.0.0 (mccabe: 0.7.0, pep8-naming: 0.13.3, pycodestyle: 2.11.1, pyflakes: 3.2.0) CPython 3.10.12 on Linux

@degenaro degenaro closed this as completed May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants