From e15886335380828fb3b524475487684231e7fa7d Mon Sep 17 00:00:00 2001
From: Achilleas Koutsou <achilleas@koutsou.net>
Date: Tue, 7 May 2024 19:08:45 +0200
Subject: [PATCH] test/scripts: fail setup-osbuild-repo on bad repo

When testing with "pinned" osbuild commit IDs (defined in the
Schutzfile), we set up a repository based on the commit ID that should
exist for each commit in osbuild that had a (partially) successful CI
run (the RPM jobs should at least run successfully).

When a repository doesn't exist for whatever reason (the CI pipeline
failed, the commit ID was copied incorrectly, etc), the setup script
wouldn't fail and osbuild would be installed from the system
repositories.  This means that we're not testing what we think we are
testing.  In the best case our build jobs fail because the osbuild
version in the repos isn't new enough to have all the features we're
testing, but we might also end up having passing tests that aren't
testing what we want, for example a change in osbuild internals that's
on an open PR and we want to verify that none or our test image builds
are broken.

Make the setup-osbuild-repo script check that the repository metadata is
reachable and exit with an error if it's not, making any test pipeline
that requires it fail when necessary instead of silently skipping the
repo configuration.
---
 test/scripts/setup-osbuild-repo | 27 +++++++++++++++++++++++++--
 1 file changed, 25 insertions(+), 2 deletions(-)

diff --git a/test/scripts/setup-osbuild-repo b/test/scripts/setup-osbuild-repo
index 5e86ff3f9c..ea42fe26ec 100755
--- a/test/scripts/setup-osbuild-repo
+++ b/test/scripts/setup-osbuild-repo
@@ -3,27 +3,50 @@
 # Add a repository configuration to install the osbuild rpm at a specific
 # commit if specified.
 import os
+import sys
+import urllib.error
+import urllib.request
 
 import imgtestlib as testlib
 
 REPO_TEMPLATE = """
 [osbuild]
 name=osbuild {commit}
-baseurl=http://osbuild-composer-repos.s3-website.us-east-2.amazonaws.com/{repo_path}
+baseurl={baseurl}
 enabled=1
 gpgcheck=0
 priority=10
 """
 
 REPO_FILE = "/etc/yum.repos.d/osbuild.repo"
+URL_TEMPLATE = "http://osbuild-composer-repos.s3-website.us-east-2.amazonaws.com/{repo_path}"
+
+
+def baseurl(repo_path):
+    return URL_TEMPLATE.format(repo_path=repo_path)
+
+
+def check_baseurl(url):
+    print(f"Checking URL {url}")
+    try:
+        with urllib.request.urlopen(url, timeout=30) as resp:
+            print(f"{resp.status} ({resp.msg})")
+    except urllib.error.HTTPError as http_error:
+        print(http_error)
+        sys.exit(1)
 
 
 def write_repo(commit, distro_version):
     arch = os.uname().machine
     repo_path = f"osbuild/{distro_version}/{arch}/{commit}"
+    repo_baseurl = baseurl(repo_path)
+
+    repomd_url = repo_baseurl + "/repodata/repomd.xml"
+    check_baseurl(repomd_url)
+
     print(f"Setting up dnf repository for {commit} ({repo_path})")
     with open("/etc/yum.repos.d/osbuild.repo", "w", encoding="utf-8") as repofile:
-        repofile.write(REPO_TEMPLATE.format(commit=commit, repo_path=repo_path))
+        repofile.write(REPO_TEMPLATE.format(commit=commit, baseurl=repo_baseurl))
 
 
 def main():