From d9967c3411218664f5216b9cfd38194d63e38d77 Mon Sep 17 00:00:00 2001 From: Achilleas Koutsou Date: Mon, 11 Sep 2023 14:43:16 +0200 Subject: [PATCH 1/2] HACKING: fix indentation of manifest generation substeps --- HACKING.md | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/HACKING.md b/HACKING.md index 87db54fa34..a27786293f 100644 --- a/HACKING.md +++ b/HACKING.md @@ -46,17 +46,17 @@ a new image type, might be: 1. Generate the manifests for the image types that you will be working on. 2. Make changes in an existing image definition or add a new image type. 3. Add appropriate configuration changes: - - If a new image type is added, add it to the [config - map](test/config-map.json) under an appropriate configuration file or write - a new one. - - If an existing image type is being modified, and the change depends on an - image customization, make sure the modification is covered by an existing - [test config](test/configs). + - If a new image type is added, add it to the [config + map](test/config-map.json) under an appropriate configuration file or + write a new one. + - If an existing image type is being modified, and the change depends on an + image customization, make sure the modification is covered by an existing + [test config](test/configs). 4. Generate the relevant manifests without content (`-packages=false -containers=false -commits=false`). - - If the change depends on a customization, it might be more useful to - generate multiple manifests with different configuration options set and - inspect the differences between them. + - If the change depends on a customization, it might be more useful to + generate multiple manifests with different configuration options set and + inspect the differences between them. 5. Inspect the differences between manifests generated in steps 0 and 3. 6. Generate manifest with all content enabled for the relevant image types. 7. Build at least one of the manifests using `osuild` and inspect the output From 211eceb73f1efa5df2cb103c8cb82679b8b58333 Mon Sep 17 00:00:00 2001 From: Achilleas Koutsou Date: Mon, 11 Sep 2023 14:43:34 +0200 Subject: [PATCH 2/2] HACKING: fix reference to steps 1 and 4. --- HACKING.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/HACKING.md b/HACKING.md index a27786293f..f441406fb4 100644 --- a/HACKING.md +++ b/HACKING.md @@ -57,7 +57,7 @@ a new image type, might be: - If the change depends on a customization, it might be more useful to generate multiple manifests with different configuration options set and inspect the differences between them. -5. Inspect the differences between manifests generated in steps 0 and 3. +5. Inspect the differences between manifests generated in steps 1 and 4. 6. Generate manifest with all content enabled for the relevant image types. 7. Build at least one of the manifests using `osuild` and inspect the output (boot the image or mount it to look for the desired changes).