Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move build from positional args to named. #31

Open
supakeen opened this issue Dec 20, 2024 · 1 comment
Open

Move build from positional args to named. #31

supakeen opened this issue Dec 20, 2024 · 1 comment
Labels
🪄 enhancement New feature or request

Comments

@supakeen
Copy link
Member

It'd be nicer if the image-builder build subcommand takes named arguments instead of positional arguments. Currently it looks like this:

image-builder build --distro fedora-41 minimal-raw blueprint.toml

I propose:

image-builder build --distro fedora-41 --type minimal-raw --blueprint blueprint.toml

This would allow for multi-type builds (a very strong advantage of the osbuild system):

image-builder build --distro fedora-41 --type iso --type qcow2 --blueprint blueprint.toml

And would allow us to in the future have other inputs except the built-in image types such as a custom YAML file for custom images.

@supakeen supakeen added the 🪄 enhancement New feature or request label Dec 20, 2024
@mvo5
Copy link
Collaborator

mvo5 commented Dec 20, 2024

Fwiw, I like that it's more "uniform" this way, i.e. to me it feels a bit unbalanced that we currently have "--distro centos-9" but type is just an positional argument and has no --type. But then its a bit more typing for our users.

We should probably have a brainstorm again in the new year.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🪄 enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants