Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chrome "access by click" gives zero errors #143

Open
aviv1620 opened this issue Jul 30, 2023 · 8 comments
Open

Chrome "access by click" gives zero errors #143

aviv1620 opened this issue Jul 30, 2023 · 8 comments
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@aviv1620
Copy link
Contributor

chrome settings have a way to give extensions access permission only on click.
not every time I load the page.
If I apply this setting, the extension "works" but says zero issues. not show any error.

Attach a screenshot.
1
2

@baruchiro baruchiro changed the title bug. if I want give access on click, I get zero issues. Chrome "access by click" gives zero errors Jul 30, 2023
@baruchiro baruchiro added the bug Something isn't working label Jul 30, 2023
@baruchiro
Copy link
Collaborator

OK, it will require some investigation, I didn't know this feature and will debug it.

@baruchiro
Copy link
Collaborator

I can't find where to configure the "access by click". Can you show me?

@aviv1620
Copy link
Contributor Author

aviv1620 commented Aug 4, 2023

Untitled
step 1: disable the "Automatically allow access on the following sites"
step 2: click on the puzzle icon. then click on the Overlay.
step 3: refresh

@baruchiro
Copy link
Collaborator

To see the errors you need to inspect the Service Worker
image

I played with that, I'm not sure what the problem is.
Of course, the Service Worker was blocked when I turned the "automatically allow" off. But I didn't managed to enable it again.

@baruchiro baruchiro added the help wanted Extra attention is needed label Aug 7, 2023
@aviv1620
Copy link
Contributor Author

aviv1620 commented Aug 7, 2023

I play with this.
If I stay the Devtool window open it acting weird.
Fortunately if the "Collect errors" enable it is possible to see the error after a bug occurs.

so here the new instruction:
step 1: disable the "Automatically allow access on the following sites"
step 2: close all the tabs. close the browser completely. close also the "Devtool" window.
step 3: open website with node-sass like this
https://stackoverflow.com/questions/29461831/libsass-bindings-not-found-when-using-node-sass-in-nodejs

step 4: you see the extension mark 0 issues in node-sass
Although if you not follow the steps, the extension mark 2 issues.
Screenshot 2023-08-07 100246

step 5: only when you see the extension mark 0 issues in node-sass open the Devtool window.
the error that logs it.
Access to fetch at 'https://debricked.com/select/get-model-structure' from origin 'chrome-extension://fahpefingaaldhifdbnlipfjniabkiho' has been blocked by CORS policy: No 'Access-Control-Allow-Origin' header is present on the requested resource. If an opaque response serves your needs, set the request's mode to 'no-cors' to fetch the resource with CORS disabled.
TypeError: Failed to fetch at background.js:1417:27 at cache (background.js:1350:43) at getModelStructure (background.js:1415:5) at fetchDebricked (background.js:1432:25) at handleAsyncError (background.js:18206:21) at advisories (background.js:18225:18) at async listener (background.js:18235:24) 'fetchDebricked' [{…}]

Screenshot 2023-08-07 100850

@baruchiro
Copy link
Collaborator

OK, showing 0 results if you disable the "Automatically allow access on the following sites" is the expected behavior.

Could you let me know what you expected?

@aviv1620
Copy link
Contributor Author

aviv1620 commented Aug 7, 2023

0 results it like "the library it safe and I can use it"
I expect message "no permission" or something like that

@baruchiro
Copy link
Collaborator

OK, it is similar to something we saw on the first day- what if a package does not actually exist?
As you said, it will report for 0 issues, but it should alert that this package doesn't exist, or ignore it.

We are waiting for @jossef TO FINISH HIS UI DESIGN 😂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants