Merge superset-ui-plugins-deckgl PR#43

[MichaelTiemannOSC]

Describe the bug
The deck.gl visualization plugin renders legend text as NULL. There is a PR that fixes it (from back in August), but it was missed in the multirepo merge.

To Reproduce
See apache-superset/superset-ui-plugins-deckgl#43

Expected behavior
Legends have proper text, not NaNs

Screenshots
If applicable, add screenshots to help explain your problem.

Additional context
apache/superset#15738

Noise has been made that this feature should land in 1.4, but I don't know. We should merge this PR so that we can render more kinds of maps with legends. And hopefully it will be fixed when we do our next major version update.

[HumairAK]

Don't think we want to start maintaining a separate image for superset that is not backed by a proper release. To ensure stability we should stick the the released versions, and wait for this to be included in either 1.4 or whichever version it makes it in.

@erikerlandson @rimolive

[erikerlandson]

If this is blocking something important and time sensitive I am OK with going off release, but I agree with Humair that it is preferable to stick to supported releases.

So the question is where this lives on the risk/reward curve.

[MichaelTiemannOSC]

If somebody can spin this up for me, I can test it and potentially vote:

https://github.com/apache/superset/releases/tag/1.4.0rc1

[erikerlandson]

Would be fine with deploying a release candidate

[MichaelTiemannOSC]

n.b. The SuperSet team rescinded the vote for rc1 and have retreated to bugfix, cherry-pick other features, and offer a new rc2 for a vote. That was expected to happen in early December, but has not happened yet. We should delay upgrading until rc2 gets some good preliminary reviews.

[MichaelTiemannOSC]

rc3 is available for review and testing: https://github.com/apache/superset/releases/tag/1.4.0rc3

[MichaelTiemannOSC]

rc4 is now available for review and testing: https://dist.apache.org/repos/dist/dev/superset/1.4.0rc4/

You can vote for it here: apache/superset#18018

[MichaelTiemannOSC]

There was a small glitch in the 1.4.0 cherry-picking process that caused one feature to interact with another. The fix is trivial and is being suggested to be merged into 1.4.1: https://lists.apache.org/[email protected]

But if we deploy 1.4.0, we should apply this one-liner so as not to lose one of the cherries picked.

[MichaelTiemannOSC]

And just like that, 1.4.0 has been released: https://github.com/apache/superset/releases/tag/1.4.0

[HumairAK]

same as: os-climate/os_c_data_commons#116 (comment)
@rimolive or someone from odh will need to provide an odh superset image upgrade for us to leverage

[MichaelTiemannOSC]

Tracking here: opendatahub-io/odh-images#11