Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Oathkeeper does not respect TRACING_PROVIDER=otel #888

Closed
4 of 6 tasks
mdreizin opened this issue Dec 28, 2021 · 6 comments · Fixed by #1039
Closed
4 of 6 tasks

Oathkeeper does not respect TRACING_PROVIDER=otel #888

mdreizin opened this issue Dec 28, 2021 · 6 comments · Fixed by #1039
Labels
bug Something is not working.

Comments

@mdreizin
Copy link

mdreizin commented Dec 28, 2021

Preflight checklist

Describe the bug

Oathkeeper does not respect TRACING_PROVIDER=otel to use OpenTelemetry.

Reproducing the bug

docker run ... -e TRACING_PROVIDER=otel ...

Relevant log output

time=2021-12-28T23:25:00Z level=fatal msg=Unable to initialize Tracer. audience=application error=map[message:unknown tracer: otel] service_name=ORY Oathkeeper service_version=v0.38.15-beta.1

Relevant configuration

No response

Version

v0.38.15-beta.1

On which operating system are you observing this issue?

Linux

In which environment are you deploying?

Kubernetes

Additional Context

It would be nice to update ory/x to the latest version to use otel tracing provider.

@mdreizin mdreizin added the bug Something is not working. label Dec 28, 2021
@aeneasr
Copy link
Member

aeneasr commented Jan 2, 2022

We will need to upgrade ory/x! However, one problem is that ory/x has developed quite a lot since we included it here and we did not yet have the time to update ory oathkeeper's config system to the new ory/x config system. So upgrading will not be as easy as just bumping the go mod version :(

@mdreizin
Copy link
Author

mdreizin commented Jan 2, 2022

@aeneasr thank you very much for sharing that! I hope you will be able to migrate to the latest version in the further ;)

@ouranders
Copy link

It would be great to use otel, any updates on this issue @aeneasr?

@bodymindarts
Copy link

We want to bring in oath keeper as a hard dependency in our stack but this is somewhat of a blocker.

@ldb
Copy link

ldb commented Oct 24, 2022

Same here, we use OpenTelemetry for all of our tracing, not having this in Oathkeeper but in Hydra is a blocker for us.

@edude03
Copy link
Contributor

edude03 commented Nov 17, 2022

Still true in the latest release fwiw

docker run -e TRACING_PROVIDER=otel -ti oryd/oathkeeper serve
Thank you for using ORY Oathkeeper v0.40.0!

Take security seriously and subscribe to the ORY Security Newsletter. Stay on top of new patches and security insights.                                 

>> Subscribe now: http://eepurl.com/di390P <<

The configuration contains values or keys which are invalid:
tracing.provider: otel
                  ^-- value must be one of "zipkin", "jaeger", "datadog", "elastic-apm"

FATA[2022-11-17T18:09:25Z] Failed to initialize configuration            audience=application error=map[message:I[#/tracing/provider] S[#/properties/tracing/properties/provider/enum] value must be one of "zipkin", "jaeger", "datadog", "elastic-apm"] service_name=ORY Oathkeeper service_version=v0.40.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is not working.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants