Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow mulitple authenticators to work on same header #466

Closed
pike1212 opened this issue Jun 15, 2020 · 5 comments
Closed

Allow mulitple authenticators to work on same header #466

pike1212 opened this issue Jun 15, 2020 · 5 comments
Labels
feat New feature or request. stale Feedback from one or more authors is required to proceed.

Comments

@pike1212
Copy link
Contributor

pike1212 commented Jun 15, 2020

Is your feature request related to a problem? Please describe.

I would like clients to be able to call my service using either OAuth tokens or JWTs and the same header ("Authorization"). Currently, if the first one fails, the next one is never tried.

Describe the solution you'd like

Maybe a flag in one of the authenticators that tells it not to error if it can't validate the token?

@aeneasr
Copy link
Member

aeneasr commented Jun 16, 2020

Yeah that sounds like a reasonable request. I'm not sure how we could address this properly. What we really need is an AND and OR logic I guess? That will be quite horrific to define in YAML though...

IMO this should be a part of #441

@aeneasr aeneasr added the feat New feature or request. label Jun 16, 2020
@pike1212
Copy link
Contributor Author

pike1212 commented May 3, 2021

What is time frame for next gen? We are currently running a custom branch to enable this functionality

@github-actions
Copy link

github-actions bot commented May 4, 2022

Hello contributors!

I am marking this issue as stale as it has not received any engagement from the community or maintainers a year. That does not imply that the issue has no merit! If you feel strongly about this issue

  • open a PR referencing and resolving the issue;
  • leave a comment on it and discuss ideas how you could contribute towards resolving it;
  • leave a comment and describe in detail why this issue is critical for your use case;
  • open a new issue with updated details and a plan on resolving the issue.

Throughout its lifetime, Ory has received over 10.000 issues and PRs. To sustain that growth, we need to prioritize and focus on issues that are important to the community. A good indication of importance, and thus priority, is activity on a topic.

Unfortunately, burnout has become a topic of concern amongst open-source projects.

It can lead to severe personal and health issues as well as opening catastrophic attack vectors.

The motivation for this automation is to help prioritize issues in the backlog and not ignore, reject, or belittle anyone.

If this issue was marked as stale erroneous you can exempt it by adding the backlog label, assigning someone, or setting a milestone for it.

Thank you for your understanding and to anyone who participated in the conversation! And as written above, please do participate in the conversation if this topic is important to you!

Thank you 🙏✌️

@github-actions github-actions bot added the stale Feedback from one or more authors is required to proceed. label May 4, 2022
@aeneasr aeneasr removed the stale Feedback from one or more authors is required to proceed. label May 4, 2022
@a-candiotti-pvotal
Copy link

We have a similar situation.

We are attributing rights and restricting access based on audiences, which lead us to have several JWT authenticators in our configuration.

The current implementation considers that if a token does not match a JWT authenticator's audiences, the authenticator should return an Unauthorized.
Which does not work in our case

Consider the following example:

authenticators:
  - config:
      allowed_algorithms:
        - RS256
      jwks_urls:
        - 'https://trusted.com/jwks.json'
      required_scope:
        - scope1
      target_audience:
        - 'https://audience1.com'
      trusted_issuers:
        - 'https://auth.com/'
    handler: jwt
  - config:
      allowed_algorithms:
        - RS256
      jwks_urls:
        - 'https://anothertrusteddomain.com/jwks.json'
      required_scope:
        - scope1
      target_audience:
        - 'https://audience2.com'
      trusted_issuers:
        - 'https://auth.com/'
    handler: jwt

For a JWT that has the 'https://audience2.com' audience, here is the behavior we thought would occur:

  • the first authenticator refuses the token but passes the responsability to the second authenticator
  • the second one accepts the token

What happened instead:

  • the first authenticator refused the token as the audiences didn't match.

A flag in the config would indeed be a nice way to make an exception in the authenticator chain.

Copy link

Hello contributors!

I am marking this issue as stale as it has not received any engagement from the community or maintainers for a year. That does not imply that the issue has no merit! If you feel strongly about this issue

  • open a PR referencing and resolving the issue;
  • leave a comment on it and discuss ideas on how you could contribute towards resolving it;
  • leave a comment and describe in detail why this issue is critical for your use case;
  • open a new issue with updated details and a plan for resolving the issue.

Throughout its lifetime, Ory has received over 10.000 issues and PRs. To sustain that growth, we need to prioritize and focus on issues that are important to the community. A good indication of importance, and thus priority, is activity on a topic.

Unfortunately, burnout has become a topic of concern amongst open-source projects.

It can lead to severe personal and health issues as well as opening catastrophic attack vectors.

The motivation for this automation is to help prioritize issues in the backlog and not ignore, reject, or belittle anyone.

If this issue was marked as stale erroneously you can exempt it by adding the backlog label, assigning someone, or setting a milestone for it.

Thank you for your understanding and to anyone who participated in the conversation! And as written above, please do participate in the conversation if this topic is important to you!

Thank you 🙏✌️

@github-actions github-actions bot added the stale Feedback from one or more authors is required to proceed. label Apr 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat New feature or request. stale Feedback from one or more authors is required to proceed.
Projects
None yet
Development

No branches or pull requests

3 participants