Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keto Warden Authorizer: Make Subject configurable. #128

Closed
lsjostro opened this issue Oct 20, 2018 · 2 comments
Closed

Keto Warden Authorizer: Make Subject configurable. #128

lsjostro opened this issue Oct 20, 2018 · 2 comments

Comments

@lsjostro
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Make Subject configurable instead of hard coding to session.Subject
https://github.com/lsjostro/oathkeeper/blob/master/proxy/authorizer_keto_warden.go#L96

Describe the solution you'd like
Would be nice to be able to pass something from the Extra attribute. i.e session.Extra["email"], as Subject to Keto. Maybe use the same implementation as in headers in Credentials Issuers using go templates?
@aeneasr
Copy link
Member

aeneasr commented Oct 21, 2018

Yeah that makes sense I guess!

@lsjostro
Copy link
Contributor Author

cool! I'll propose a PR.

@lsjostro lsjostro mentioned this issue Oct 22, 2018
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lsjostro @aeneasr