Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing serve all, both proxy/api using 4455 #122

Closed
mmellison opened this issue Oct 3, 2018 · 3 comments
Closed

Missing serve all, both proxy/api using 4455 #122

mmellison opened this issue Oct 3, 2018 · 3 comments
Labels
feat New feature or request.
Milestone

Comments

@mmellison
Copy link

mmellison commented Oct 3, 2018

It appears that Oathkeeper is missing a serve all command similar to Hydra. This would be useful for launching both in a single container.

Likewise, both the serve proxy and serve api commands bind to port 4455, even though the help documentation states the api will bind to port 4456 by default.

@bensont1
Copy link

bensont1 commented Oct 6, 2018

I think it was intended this way because the proxy is meant to be public facing routing, while the API is the management portion of oathkeeper.

@mmellison
Copy link
Author

Absolutely!

It just makes it easier to deploy into K8S if we can run both in the same container. Currently we have to define two separate containers in our pod (which works just fine). It'd just be a "nice to have" if we could run both at the same time and have the proxy run on 4455 and api run on 4456.

@aeneasr
Copy link
Member

aeneasr commented Oct 8, 2018

Yeah this could be added at some point, tracking as enhancement!

@aeneasr aeneasr added the feat New feature or request. label Oct 8, 2018
@aeneasr aeneasr added this to the unplanned milestone Oct 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat New feature or request.
Projects
None yet
Development

No branches or pull requests

3 participants