Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: for remote_json authorizer, add headers #1140

Merged
merged 2 commits into from
Feb 28, 2024

Conversation

divyun
Copy link
Contributor

@divyun divyun commented Nov 29, 2023

✨(authorizers): for remote_json, introduce the ability to specify headers
⬆️ Bump github.com/ory/x to v0.0.605 to pass the build fixing vulnerabilities

Related issue(s)

#969

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    [email protected]) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

Corresponding Docs PR ory/docs#1604

@CLAassistant
Copy link

CLAassistant commented Nov 29, 2023

CLA assistant check
All committers have signed the CLA.

Copy link

codecov bot commented Nov 29, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b5d4d88) 78.16% compared to head (eff951b) 77.58%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1140      +/-   ##
==========================================
- Coverage   78.16%   77.58%   -0.59%     
==========================================
  Files          80       79       -1     
  Lines        3898     3992      +94     
==========================================
+ Hits         3047     3097      +50     
- Misses        576      616      +40     
- Partials      275      279       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@divyun divyun force-pushed the feat/authorizer-remote-json-add-headers branch 7 times, most recently from d769d2d to 031639d Compare November 30, 2023 10:36
@divyun divyun force-pushed the feat/authorizer-remote-json-add-headers branch from 031639d to eff951b Compare November 30, 2023 10:56
@divyun divyun marked this pull request as ready for review November 30, 2023 11:11
@divyun divyun requested a review from aeneasr as a code owner November 30, 2023 11:11
@divyun
Copy link
Contributor Author

divyun commented Nov 30, 2023

Code coverage is lowered due to some extra lines being tracked for internal/cloudstorage/setup.go in the code that wasn't changed in the PR. I can only assume that's due to certain dependencies being updated to pass "Code scanning" check.

HEAD: https://app.codecov.io/gh/ory/oathkeeper/pull/1140/tree/internal/cloudstorage
BASE: https://app.codecov.io/gh/ory/oathkeeper/commit/b5d4d88e69fc38c0536aef1f00155255683e815d/tree/internal/cloudstorage

Copy link
Collaborator

@alnr alnr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Copy link
Member

@aeneasr aeneasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you! 🎉 Your contribution makes Ory better :)

@aeneasr aeneasr merged commit 1ee445d into ory:master Feb 28, 2024
24 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants