Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: sqa metrics v2 #1110

Merged
merged 1 commit into from
Jun 7, 2023
Merged

feat: sqa metrics v2 #1110

merged 1 commit into from
Jun 7, 2023

Conversation

misamu
Copy link
Contributor

@misamu misamu commented Jun 2, 2023

SQA metrics V2 payloads

Related issue(s)

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    [email protected]) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

@misamu misamu requested a review from aeneasr as a code owner June 2, 2023 12:48
@codecov
Copy link

codecov bot commented Jun 2, 2023

Codecov Report

Merging #1110 (5071268) into master (1857ba3) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 5071268 differs from pull request most recent head 5c910e7. Consider uploading reports for the commit 5c910e7 to get more accurate results

@@           Coverage Diff           @@
##           master    #1110   +/-   ##
=======================================
  Coverage   77.64%   77.64%           
=======================================
  Files          80       80           
  Lines        3963     3963           
=======================================
  Hits         3077     3077           
  Misses        607      607           
  Partials      279      279           
Impacted Files Coverage Δ
cmd/server/server.go 72.15% <100.00%> (ø)

@aeneasr aeneasr merged commit baeecc6 into ory:master Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants