Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Identify oidc Microsoft user by id received from https://graph.microsoft.com/v1.0/me #2150

Closed
5 of 6 tasks
splaunov opened this issue Jan 17, 2022 · 1 comment
Closed
5 of 6 tasks
Labels
feat New feature or request.
Milestone

Comments

@splaunov
Copy link
Contributor

splaunov commented Jan 17, 2022

Preflight checklist

Describe your problem

In PHP world the socialite lib is a popular solution for OAuth logins such as Google, Apple and others.
In case of Microsoft provider they read user info from https://graph.microsoft.com/v1.0/me instead of the standard OAuth userinfo endpoint. This means that such users are identified by id received from me endpoint and not by sub field from userinfo.
https://github.com/SocialiteProviders/Microsoft/blob/3f4ec79e65c3a403a5fe70cccd28d23802f1981e/Provider.php#L64
This makes it hard to migrate PHP systems to Kratos, as oidc Microsoft provider in Kratos relies on sub field as user identifier.

Describe your ideal solution

Extend Microsoft oidc provider in Kratos to support this case.
Would you accept such PR?

Workarounds or alternatives

Implement a service to process requests before they come to Kratos and convert identifiers.
The conversion might take long or even never end if some users might not choose to re-logion for long.

Version

0.8

Additional Context

No response

@splaunov splaunov added the feat New feature or request. label Jan 17, 2022
@aeneasr aeneasr added this to the Stable Release milestone Mar 7, 2022
@aeneasr
Copy link
Member

aeneasr commented Apr 5, 2022

Addressednon master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat New feature or request.
Projects
None yet
Development

No branches or pull requests

2 participants