Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix obvious typo #2114

Merged
merged 2 commits into from
Jan 8, 2022
Merged

Fix obvious typo #2114

merged 2 commits into from
Jan 8, 2022

Conversation

mritalian
Copy link
Contributor

No description provided.

@CLAassistant
Copy link

CLAassistant commented Jan 6, 2022

CLA assistant check
All committers have signed the CLA.

@mritalian mritalian changed the title obvious typo Fix obvious typo Jan 6, 2022
@codecov
Copy link

codecov bot commented Jan 6, 2022

Codecov Report

Merging #2114 (c6e4181) into master (1f3b196) will increase coverage by 0.01%.
The diff coverage is n/a.

❗ Current head c6e4181 differs from pull request most recent head 982b8a3. Consider uploading reports for the commit 982b8a3 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2114      +/-   ##
==========================================
+ Coverage   75.14%   75.15%   +0.01%     
==========================================
  Files         293      293              
  Lines       15600    15600              
==========================================
+ Hits        11722    11724       +2     
+ Misses       3041     3040       -1     
+ Partials      837      836       -1     
Impacted Files Coverage Δ
persistence/sql/persister_courier.go 88.33% <0.00%> (+3.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f3b196...982b8a3. Read the comment docs.

Copy link
Member

@aeneasr aeneasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for your contribution to the documentation! Due to the way Docusaurus versioning works, you need to make the changes in two locations:

  • docs/versioned_docs/version-v{version}/path/to/file
  • docs/docs/path/to/file

Without making them in both locations, the changes will most likely be lost when releasing another version. Thank you! :)

@mritalian
Copy link
Contributor Author

Thank you very much for your contribution to the documentation! Due to the way Docusaurus versioning works, you need to make the changes in two locations:

  • docs/versioned_docs/version-v{version}/path/to/file
  • docs/docs/path/to/file

Without making them in both locations, the changes will most likely be lost when releasing another version. Thank you! :)

Makes sense. Done.

@aeneasr aeneasr merged commit a7a16d7 into ory:master Jan 8, 2022
@vinckr
Copy link
Member

vinckr commented Jan 12, 2022

Hello @mritalian
Congrats on merging your first PR in Ory 🎉 !
Your contribution will soon be helping secure millions of identities around the globe 🌏.
As a small token of appreciation we send all our first time contributors a gift package to welcome them to the community.
Please drop me an email to claim your Ory swag!

peturgeorgievv pushed a commit to senteca/kratos-fork that referenced this pull request Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants