Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add preset CSP nonce #2096

Merged
merged 1 commit into from
Jan 2, 2022
Merged

feat: add preset CSP nonce #2096

merged 1 commit into from
Jan 2, 2022

Conversation

aeneasr
Copy link
Member

@aeneasr aeneasr commented Jan 2, 2022

Closes ory/kratos-selfservice-ui-node#162

Related issue(s)

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security. vulnerability, I
    confirm that I got green light (please contact
    [email protected]) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

@aeneasr aeneasr requested a review from zepatrik as a code owner January 2, 2022 12:55
@codecov
Copy link

codecov bot commented Jan 2, 2022

Codecov Report

Merging #2096 (67ae187) into master (4b541af) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2096      +/-   ##
==========================================
- Coverage   75.01%   75.00%   -0.02%     
==========================================
  Files         293      293              
  Lines       15373    15374       +1     
==========================================
- Hits        11532    11531       -1     
- Misses       3012     3013       +1     
- Partials      829      830       +1     
Impacted Files Coverage Δ
ui/node/attributes.go 60.86% <ø> (ø)
ui/node/attributes_input.go 87.15% <100.00%> (+0.11%) ⬆️
persistence/sql/persister_courier.go 85.00% <0.00%> (-3.34%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b541af...67ae187. Read the comment docs.

@aeneasr aeneasr merged commit 8913292 into master Jan 2, 2022
@aeneasr aeneasr deleted the close-ui-162 branch January 2, 2022 13:55
peturgeorgievv pushed a commit to senteca/kratos-fork that referenced this pull request Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use nonce attribute when loading scripts
1 participant