feat(oidc): add spotify provider #2024
Conversation
| Email: user.Email, | ||
| Picture: userPicture, | ||
| Profile: user.ExternalURLs["spotify"], | ||
| Birthdate: user.Birthdate, |
There was a problem hiding this comment.
Hey there! I'm looking to make a contribution here in order to get Country from the Spotify API. Would it be simple as adding Country: user.country into the Claims struct here?
My apologies - I'm not familiar with the providers or Go. But I'd love to make my first very simple contribution to Kratos.
Should this change be accepted, what is the average turn-around on a release for a non-breaking change like this making it to Ory Cloud? This is a requirement for a system I am building.
There was a problem hiding this comment.
Would it be simple as adding Country: user.country into the Claims struct here?
Not sure, but I suggest you try it with a local Kratos instance and your patch. Make sure to check the spotify docs on the exact key and scopes needed.
what is the average turn-around on a release for a non-breaking change like this making it to Ory Cloud?
Days, but we can prioritize this when requested.
There was a problem hiding this comment.
The country of the user, as set in the user's account profile. An ISO 3166-1 alpha-2 country code. This field is only available when the current user has granted access to the user-read-private scope.
from https://developer.spotify.com/documentation/web-api/reference/#/operations/get-current-users-profile
Co-authored-by: Keith Mitchell <[email protected]>
Related issue(s)
Closes #1985
Checklist
introduces a new feature.
contributing code guidelines.
vulnerability. If this pull request addresses a security. vulnerability, I
confirm that I got green light (please contact
[email protected]) from the maintainers to push
the changes.
works.
Further Comments