Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Hash type detection improvements #1378

Closed
harnash opened this issue May 26, 2021 · 2 comments
Closed

Feat: Hash type detection improvements #1378

harnash opened this issue May 26, 2021 · 2 comments
Labels
feat New feature or request. rfc A request for comments to discuss and share ideas.
Milestone

Comments

@harnash
Copy link
Contributor

harnash commented May 26, 2021

Background

This is the follow-up of the discussions in #1332. As mentioned in that PR it would be nice to not rely on the hash format (prefix/ID etc.) to determine the type of the hash. Since not all hash algorithms uses Modular Crypt Format or PHC string format and comparing some arbitrary prefixes is risky and not straightforward it would be nice to have a better solution.

Proposal

Ideally it would be to keep the information about the type of the hash in the credentials config. This would cleanup the code and allow some other operations to be done easily on the hashes (statistics, audits, etc.). It would also allow cleaner implementation of some legacy hashers and perhaps help with #605.

@harnash harnash changed the title Hash type detection improvements Feat: Hash type detection improvements May 26, 2021
@aeneasr aeneasr added feat New feature or request. rfc A request for comments to discuss and share ideas. labels May 27, 2021
@aeneasr aeneasr added this to the v0.10.0-alpha.1 milestone Mar 7, 2022
@aeneasr aeneasr modified the milestones: v0.10.0-alpha.1, v1.0.0 May 30, 2022
@aeneasr
Copy link
Member

aeneasr commented Mar 13, 2023

We now support PHC

@aeneasr aeneasr closed this as completed Mar 13, 2023
@aeneasr
Copy link
Member

aeneasr commented Mar 13, 2023

Sorry, misread the issue. Still closing though due to lack of (public) interest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat New feature or request. rfc A request for comments to discuss and share ideas.
Projects
None yet
Development

No branches or pull requests

2 participants