Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade deprecated grpc-tools to @grpc/grpc-js #835

Closed
3 of 6 tasks
aeneasr opened this issue Feb 9, 2022 · 2 comments
Closed
3 of 6 tasks

Upgrade deprecated grpc-tools to @grpc/grpc-js #835

aeneasr opened this issue Feb 9, 2022 · 2 comments
Labels
bug Something is not working.

Comments

@aeneasr
Copy link
Member

aeneasr commented Feb 9, 2022

Preflight checklist

Describe the bug

grpc-tools does not work with Apple M1 as darwin arm64 binaries are missing, thus it is not possible to run tasks like make buf on an Apple M1 chip.

grpc-tools is deprectead, and maintainers encourage to use @grpc/grpc-js instead.

Reproducing the bug

See above

Relevant log output

No response

Relevant configuration

No response

Version

master

On which operating system are you observing this issue?

No response

In which environment are you deploying?

No response

Additional Context

No response

@aeneasr aeneasr added the bug Something is not working. label Feb 9, 2022
@zepatrik
Copy link
Member

grpc-tools is not deprecated and does something completely different than @grpc/grpc-js. We already use @grpc/grpc-js instead of the deprecated grpc package.
However, I overhauled and upgraded the buf and protoc pipeline in #1097. I hope that works on apple arm chips now.

@zepatrik
Copy link
Member

The new version should work on mac/arm grpc/grpc-node#1405 (comment) outside of docker at least.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is not working.
Projects
None yet
Development

No branches or pull requests

2 participants