Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot connect to MySQL #145

Closed
jboalml opened this issue Jan 4, 2020 · 4 comments
Closed

Cannot connect to MySQL #145

jboalml opened this issue Jan 4, 2020 · 4 comments

Comments

@jboalml
Copy link

jboalml commented Jan 4, 2020

Describe the bug

It is not possible to connect to MySQL using the DSN format.

Reproducing the bug

The issue is related to a change in Golang and was first reported here: golang-migrate/migrate#264

Expected behavior

Keto should be able to connect to MySQL.

Environment

  • Keto versions: Higher than v0.3.3 (it works in v0.3.3)
  • Environment: Tested in Docker

Additional context

The issue has already been fixed: golang-migrate/migrate#265
Most probably the solution is simply to update the Go version.

@aeneasr
Copy link
Member

aeneasr commented Jan 7, 2020

Thank you for the report - would you be up for version bump / PR? :)

@yuan1238y
Copy link

Hello @aeneasr .
This bug not repaired completely.

keto-migrate_1  | time="2020-03-05T09:28:49Z" level=fatal msg="Unable to parse configuration item \"dsn\", make sure it has the right format" dsn="mysql://root:eisoo.com@tcp(mysql:3306)/keto?max_conns=20&max_idle_conns=4" error="parse \"mysql://root:eisoo.com@tcp(mysql:3306)/keto?max_conns=20&max_idle_conns=4\": invalid port \":3306)\" after host"

The dependency library github.com/ory/x version is v0.0.93, currently latest version is v0.0.99, and fixed this bug https://github.com/ory/x/commit/f09f5c955c86b9aa3eed222775da5020fbfce065

@aeneasr
Copy link
Member

aeneasr commented Mar 5, 2020

Ah right, that still has to be fixed - would you be up for a PR? :)

@yuan1238y
Copy link

yuan1238y commented Mar 6, 2020

Ah right, that still has to be fixed - would you be up for a PR? :)

😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants