From 780446c27b328fe819a3f4011ea88991626737f8 Mon Sep 17 00:00:00 2001 From: aeneasr <3372410+aeneasr@users.noreply.github.com> Date: Fri, 5 Feb 2021 16:55:29 +0100 Subject: [PATCH] fix: resolve regression --- authorize_request.go | 3 ++- authorize_request_test.go | 5 +++++ 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/authorize_request.go b/authorize_request.go index 3c047f211..dd5f0a571 100644 --- a/authorize_request.go +++ b/authorize_request.go @@ -49,10 +49,11 @@ type AuthorizeRequest struct { func NewAuthorizeRequest() *AuthorizeRequest { return &AuthorizeRequest{ ResponseTypes: Arguments{}, - RedirectURI: &url.URL{}, HandledResponseTypes: Arguments{}, Request: *NewRequest(), ResponseMode: ResponseModeDefault, + // The redirect URL must be unset / nil for redirect detection to work properly: + // RedirectURI: &url.URL{}, } } diff --git a/authorize_request_test.go b/authorize_request_test.go index 637ca0f7b..227cf5e26 100644 --- a/authorize_request_test.go +++ b/authorize_request_test.go @@ -22,6 +22,7 @@ package fosite import ( + "github.com/stretchr/testify/require" "net/url" "testing" "time" @@ -29,6 +30,10 @@ import ( "github.com/stretchr/testify/assert" ) +func TestAuthorizeRequestURLRegression(t *testing.T) { + require.Nil(t, NewAuthorizeRequest().RedirectURI) +} + func TestAuthorizeRequest(t *testing.T) { var urlparse = func(rawurl string) *url.URL { u, _ := url.Parse(rawurl)