fix: Fixed the missing state check for hybrid flow

[harjoben]

Related Issue or Design Document

#669 has the details of the bug

Checklist

• I have read the contributing guidelines
  and signed the CLA.
• I have referenced an issue containing the design document if my change
  introduces a new feature.
• I have read the security policy.
• I confirm that this pull request does not address a security
  vulnerability. If this pull request addresses a security vulnerability, I
  confirm that I got green light (please contact
  [email protected]) from the maintainers to push
  the changes.
• I have added tests that prove my fix is effective or that my feature
  works.
• I have added necessary documentation within the code base (if
  appropriate).

Further comments

[CLAassistant]

All committers have signed the CLA.

[harjoben]

@aeneasr The tests here are failing because they are being run in a go1.14 environment. The Has() method for url.Values is only available from go1.17 onwards. Do the tests need to be updated to use the latest go version? Or I should update my fix to not use the Has() method?

[james-d-elliott]

@aeneasr The tests here are failing because they are being run in a go1.14 environment. The Has() method for url.Values is only available from go1.17 onwards. Do the tests need to be updated to use the latest go version? Or I should update my fix to not use the Has() method?

Probably the most accessible option (not requiring go 1.17) would be to do something along the lines of this since the url.Values are just a map[string][]string:

	if _, ok := resp.GetParameters()["state"]; !ok {
		resp.AddParameter("state", ar.GetState())
	}

Edit: Keep in mind I can't really speak on anyone behalf of anyone else.

[aeneasr]

We can move to Go 1.17 :)

[harjoben]

We can move to Go 1.17 :)

@aeneasr How do we go about doing that? I don't believe I have access to update the circleci tests running for this PR.

[harjoben]

@aeneasr I believe Go was upgraded already. I don't have permissions to re-run the checks for this PR. Can you help me do that?

[james-d-elliott]

@aeneasr I believe Go was upgraded already. I don't have permissions to re-run the checks for this PR. Can you help me do that?

If you merge master into your local branch and push that should trigger a rebuild.

[aeneasr]

@harjoben can you add a test that fails the current code on master and passes with the changes you've made? Thank you!

[aeneasr]

@harjoben are you still up for the changes?

[harjoben]

@harjoben are you still up for the changes?

@aeneasr Yes, I will make the changes. Give me some time. Apologies for dragging this so long

[aeneasr]

no problem :)

[harjoben]

@aeneasr I have added the relevant test.

[james-d-elliott]

Can confirm the test fails before the fix (as expected), have not checked post fix as I'm assuming circleci will fail the check if it doesn't.

[aeneasr]

thank you!