raise bcrypt cost factor lower bound to x/crypto/bcrypt default #321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI I already emailed the security contact about this. |
adamdecaf
force-pushed
the
bcrypt-default-cost-factor
branch
from
d1e7cd1 to
3388bed
Compare
aeneasr
reviewed
Oct 25, 2018
hash_bcrypt.go
Outdated
| @@ -34,6 +34,9 @@ type BCrypt struct { | |||
| } | |||
|
|
|||
| func (b *BCrypt) Hash(ctx context.Context, data []byte) ([]byte, error) { | |||
| if b.WorkFactor == 0 { | |||
| b.WorkFactor = bcrypt.DefaultCost | |||
There was a problem hiding this comment.
Since we're defaulting to 12 I think this should also be 12. Potentially as a shared const
There was a problem hiding this comment.
I was thinking of that too. Where should that live?
Users of this library can easily create the following:
hasher := fosite.BCrypt{}
hasher.Hash(..)
This is a problem because WorkFactor will default to 0 and x/crypto/bcrypt will default that to 4 (See https://godoc.org/golang.org/x/crypto/bcrypt).
Instead this should be some higher cost factor. Callers who need a lower WorkFactor can still lower the cost, if needed.
Signed-off-by: Adam Shannon <[email protected]>
adamdecaf
force-pushed
the
bcrypt-default-cost-factor
branch
from
3388bed to
33fcf9c
Compare
|
Thanks! |
budougumi0617
added a commit
to budougumi0617/fosite
that referenced
this pull request
May 10, 2019
Users of this library can easily create the following:
hasher := fosite.BCrypt{}
hasher.Hash(..)
This is a problem because WorkFactor will default to 0 and x/crypto/bcrypt will default that to 4 (See https://godoc.org/golang.org/x/crypto/bcrypt).
Instead this should be some higher cost factor. Callers who need a lower WorkFactor can still lower the cost, if needed.
Signed-off-by: Adam Shannon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Users of this library could easily create the following:
This is a problem because
WorkFactorwill default to 0 andx/crypto/bcryptwill default that to 4 (See https://godoc.org/golang.org/x/crypto/bcrypt). Instead this should be some higher cost factor.I didn't use
config.GetHashCost()because that's in another package.Callers who need a lower WorkFactor can still lower the cost, if needed.
Checklist
vulnerability, I confirm that I got green light (please contact [email protected]) from the maintainers to push the changes.
by signing my commit(s). You can amend your signature to the most recent commit by using
git commit --amend -s. If youamend the commit, you might need to force push using
git push --force HEAD:<branch>. Please be very careful when usingforce push.