Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(table): fix table async example backend sort function #910

Merged
merged 1 commit into from
Apr 29, 2024

Conversation

dauriata
Copy link
Contributor

Proposed Changes

Fixes Table async data example when using the table sorting function
Using wrong property in sort function

Copy link

netlify bot commented Apr 27, 2024

Deploy Preview for oruga-documentation-preview ready!

Name Link
🔨 Latest commit 5a09018
🔍 Latest deploy log https://app.netlify.com/sites/oruga-documentation-preview/deploys/662d73a9c27b07000814f783
😎 Deploy Preview https://deploy-preview-910--oruga-documentation-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Apr 27, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 17.86%. Comparing base (484cfe8) to head (5a09018).
Report is 57 commits behind head on develop.

Files Patch % Lines
...oruga/src/components/table/examples/async-data.vue 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           develop     #910       +/-   ##
============================================
- Coverage    56.71%   17.86%   -38.86%     
============================================
  Files           30      292      +262     
  Lines         1511     7317     +5806     
  Branches       544     2093     +1549     
============================================
+ Hits           857     1307      +450     
- Misses         654     5059     +4405     
- Partials         0      951      +951     
Flag Coverage Δ
oruga-next 17.86% <0.00%> (-38.86%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mlmoravek mlmoravek added bug Something isn't working documentation Improvements or additions to documentation labels Apr 28, 2024
@mlmoravek mlmoravek changed the title fix(table): table doc async example backend sort function docs(table): fix table async example backend sort function Apr 28, 2024
@mlmoravek mlmoravek merged commit 18f3c00 into oruga-ui:develop Apr 29, 2024
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants