Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tabs|steps): add animation and animateInitially prop #797

Merged
merged 4 commits into from
Feb 23, 2024

Conversation

mlmoravek
Copy link
Member

@mlmoravek mlmoravek commented Feb 23, 2024

Fixes #769

Proposed Changes

  • add animation prop to tabs and steps component
  • add animateInitially prop to tabs and steps component
  • disable transition when animation prop is false for tabs and steps component
  • fix tabs and steps component animation mismatch

@mlmoravek mlmoravek added the enhancement Improvements to existing features and functionality label Feb 23, 2024
Copy link

netlify bot commented Feb 23, 2024

Deploy Preview for oruga-documentation-preview ready!

Name Link
🔨 Latest commit ff1a705
🔍 Latest deploy log https://app.netlify.com/sites/oruga-documentation-preview/deploys/65d8c450c0351b0007c99f81
😎 Deploy Preview https://deploy-preview-797--oruga-documentation-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Feb 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.60%. Comparing base (6eca2c2) to head (ff1a705).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #797   +/-   ##
========================================
  Coverage    54.60%   54.60%           
========================================
  Files           31       31           
  Lines         1498     1498           
  Branches       534      534           
========================================
  Hits           818      818           
  Misses         680      680           
Flag Coverage Δ
oruga-next 54.60% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mlmoravek mlmoravek merged commit f04362e into oruga-ui:develop Feb 23, 2024
9 checks passed
@mlmoravek mlmoravek deleted the step-tab-animation branch February 23, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvements to existing features and functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Proposal: OTabs: Add animation props (as like as BTabs of Buefy)
1 participant