Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(datepicker): refactor datepicker related components #782

Merged
merged 3 commits into from
Feb 15, 2024

Conversation

mlmoravek
Copy link
Member

Fixes #780

Proposed Changes

  • fix datepicker vue internal issue
  • refactor useVModel composable to defineModel macro
  • refactor datepicker utils

@mlmoravek mlmoravek added bug Something isn't working refactoring This involves some refactoring of existing code. labels Feb 15, 2024
Copy link

netlify bot commented Feb 15, 2024

Deploy Preview for oruga-documentation-preview ready!

Name Link
🔨 Latest commit 816ba57
🔍 Latest deploy log https://app.netlify.com/sites/oruga-documentation-preview/deploys/65ce1f04e0660e0008131548
😎 Deploy Preview https://deploy-preview-782--oruga-documentation-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Feb 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (22b36a8) 54.32% compared to head (816ba57) 54.32%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #782   +/-   ##
========================================
  Coverage    54.32%   54.32%           
========================================
  Files           31       31           
  Lines         1493     1493           
  Branches       530      530           
========================================
  Hits           811      811           
  Misses         682      682           
Flag Coverage Δ
oruga-next 54.32% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mlmoravek mlmoravek changed the title fix(datepicker): refactor datepicker components fix(datepicker): refactor datepicker related components Feb 15, 2024
@mlmoravek mlmoravek merged commit da9eb0f into oruga-ui:develop Feb 15, 2024
9 checks passed
@mlmoravek mlmoravek deleted the update-datepicker branch February 15, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working refactoring This involves some refactoring of existing code.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Date(time)Picker throws error when using controls
1 participant