-
-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: enhance oruga options type #663
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for oruga-documentation-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #663 +/- ##
========================================
Coverage 59.02% 59.02%
========================================
Files 97 97
Lines 2716 2716
Branches 913 913
========================================
Hits 1603 1603
Misses 1002 1002
Partials 111 111
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
messenjer
reviewed
Nov 24, 2023
messenjer
reviewed
Nov 24, 2023
packages/oruga-next/src/components/datepicker/DatepickerTable.vue
Outdated
Show resolved
Hide resolved
messenjer
reviewed
Nov 24, 2023
packages/oruga-next/src/components/datepicker/DatepickerTableRow.vue
Outdated
Show resolved
Hide resolved
messenjer
reviewed
Nov 24, 2023
packages/oruga-next/src/components/datetimepicker/Datetimepicker.vue
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will enhance the type definition export of the OrugaOptions interface with all the config properties and component class definitions properties.
This helps when creating themes by providing an overview of all existing properties and classes.
Fixes #632
Proposed Changes