Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enhance oruga options type #663

Merged
merged 6 commits into from
Nov 28, 2023

Conversation

mlmoravek
Copy link
Member

This will enhance the type definition export of the OrugaOptions interface with all the config properties and component class definitions properties.
This helps when creating themes by providing an overview of all existing properties and classes.

Fixes #632

Proposed Changes

  • enhance oruga options type
  • adjust component class props

@mlmoravek mlmoravek self-assigned this Nov 23, 2023
Copy link

netlify bot commented Nov 23, 2023

Deploy Preview for oruga-documentation-preview ready!

Name Link
🔨 Latest commit 11400cf
🔍 Latest deploy log https://app.netlify.com/sites/oruga-documentation-preview/deploys/6565cb9d92e95b00086109b0
😎 Deploy Preview https://deploy-preview-663--oruga-documentation-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Nov 23, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6e2aa5d) 59.02% compared to head (11400cf) 59.02%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #663   +/-   ##
========================================
  Coverage    59.02%   59.02%           
========================================
  Files           97       97           
  Lines         2716     2716           
  Branches       913      913           
========================================
  Hits          1603     1603           
  Misses        1002     1002           
  Partials       111      111           
Flag Coverage Δ
oruga 67.21% <ø> (ø)
oruga-next 50.98% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mlmoravek mlmoravek merged commit 78df3e9 into oruga-ui:develop Nov 28, 2023
@mlmoravek mlmoravek deleted the feature_theme_type branch November 28, 2023 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Type ThemeConfig export
2 participants