Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setupWithAnalytics missing support for Firebase #291

Open
ScottYelich opened this issue Sep 12, 2016 · 3 comments
Open

setupWithAnalytics missing support for Firebase #291

ScottYelich opened this issue Sep 12, 2016 · 3 comments

Comments

@ScottYelich
Copy link

ScottYelich commented Sep 12, 2016

setupWithAnalytics missing support for Firebase (ARAnalytics 4.0.0)

Perhaps: ARFIRAnalyticsKey

+ (void)setupWithAnalytics:(NSDictionary *)analyticsDictionary {
// ...
    if (analyticsDictionary[ARFIRAnalyticsKey]) {
        [self setupFirebaseAnalytics]; // :analyticsDictionary[ARFIRAnalyticsKey]];
    }

@orta
Copy link
Owner

orta commented Sep 12, 2016

Cool, wanna add that?

@ScottYelich
Copy link
Author

I've added it locally... after I test it out and get Firebase working... I'd feel more comfortable making a PR.

@orta
Copy link
Owner

orta commented Sep 12, 2016

Awesome 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants