Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BP5 + operator for local array #3987

Closed
pnorbert opened this issue Jan 8, 2024 · 4 comments
Closed

BP5 + operator for local array #3987

pnorbert opened this issue Jan 8, 2024 · 4 comments
Assignees
@eisenhauer
Labels
sustainability Related to sustainability effort

Comments

@pnorbert
Copy link
Contributor

pnorbert commented Jan 8, 2024

Apparently, BP5 does not support operators for local arrays, neither for writing nor reading.
@eisenhauer
Copy link
Member

Hmmm. No tests for that anywhere? From a quick glance at BP5 serializer, they should be supported for everything that's not a single value, but maybe there's a non-obvious problem.

@eisenhauer eisenhauer self-assigned this Jan 8, 2024
@eisenhauer
Copy link
Member

Well, the logic for operator block sizing is missing on the read side for the Local case in GenerateReadRequests... Might be more stuff, but it's where I'm starting.

@eisenhauer eisenhauer mentioned this issue Jan 8, 2024
Merged
@eisenhauer
Copy link
Member

Quick PR submitted. It needs better test cases, but if you have one, give this a go.

@pnorbert
Copy link
Contributor Author

pnorbert commented Jan 9, 2024

Fixed by #3989

@pnorbert pnorbert closed this as completed Jan 9, 2024
@pnorbert pnorbert added the sustainability Related to sustainability effort label Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eisenhauer eisenhauer

Labels
sustainability Related to sustainability effort
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@eisenhauer @pnorbert