Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

herr_t represents failure when <= 0, but gADIOS2ReadVar considers == 0 success. #3518

Open
vicentebolea opened this issue Mar 2, 2023 · 0 comments
Open

herr_t represents failure when <= 0, but gADIOS2ReadVar considers == 0 success. #3518

vicentebolea opened this issue Mar 2, 2023 · 0 comments
Labels
api: C++ C++ API related

Comments

@vicentebolea
Copy link
Collaborator

vicentebolea commented Mar 2, 2023 •
edited
Loading

A note for the future: according to hdf5 docs: https://docs.hdfgroup.org/hdf5/develop/_h5public_8h.html#title52 . A herr_t represents failure when <= 0, but gADIOS2ReadVar considers == 0 success. No something to change in this MR, but it will be good to address it in the future either getting rid of using herr_t in our codebase or following the hdf5 usage of it.

Originally posted by @vicentebolea in #3516 (comment)
@spyridon97 spyridon97 self-assigned this Nov 8, 2023
@vicentebolea vicentebolea added area: build Build issues api: C++ C++ API related and removed area: build Build issues labels Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
api: C++ C++ API related
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vicentebolea @spyridon97