Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Joined arrays are not working properly anymore #1576

Closed
pnorbert opened this issue Jun 29, 2019 · 3 comments
Closed

Joined arrays are not working properly anymore #1576

pnorbert opened this issue Jun 29, 2019 · 3 comments
Assignees

Comments

@pnorbert
Copy link
Contributor

examples/basics/joinedArray/joinedArray_write.cpp

The variable 'table' is supposed to be a global array, but it shows up as a bunch of local arrays now. Both BP3 and BP4.

$ mpirun -n 4 ./bin/joinedArray_write

$ ./bin/bpls -laD joinedArray.bp
  double   table  5*[4]*{__, 4} = 0 / 3.93
        step 0: 
          block 0: [0:5, 0:3] = 0 / 0.53
          block 1: [0:9, 0:3] = 1 / 1.93
          block 2: [0:4, 0:3] = 2 / 2.43
          block 3: [0:9, 0:3] = 3 / 3.93
        step 1: 
          block 0: [0:5, 0:3] = 0 / 0.53
          block 1: [0:9, 0:3] = 1 / 1.93
          block 2: [0:4, 0:3] = 2 / 2.43
          block 3: [0:9, 0:3] = 3 / 3.93
        step 2: 
          block 0: [0:5, 0:3] = 0 / 0.53
          block 1: [0:9, 0:3] = 1 / 1.93
          block 2: [0:4, 0:3] = 2 / 2.43
          block 3: [0:9, 0:3] = 3 / 3.93
        step 3: 
          block 0: [0:5, 0:3] = 0 / 0.53
          block 1: [0:9, 0:3] = 1 / 1.93
          block 2: [0:4, 0:3] = 2 / 2.43
          block 3: [0:9, 0:3] = 3 / 3.93
        step 4: 
          block 0: [0:5, 0:3] = 0 / 0.53
          block 1: [0:9, 0:3] = 1 / 1.93
          block 2: [0:4, 0:3] = 2 / 2.43
          block 3: [0:9, 0:3] = 3 / 3.93
@pnorbert pnorbert added the bug label Jun 29, 2019
@pnorbert pnorbert added this to the 2.4.0 Production Release milestone Jun 29, 2019
@williamfgc
Copy link
Contributor

williamfgc commented Jun 29, 2019

@pnorbert JoinedDims never worked, you can see there is no tests. The decision was to push this for later since there was no immediate need from apps and prioritize other features for this release.

@pnorbert pnorbert added enhancement and removed bug labels Jun 29, 2019
@pnorbert pnorbert removed this from the 2.4.0 Production Release milestone Jun 29, 2019
@williamfgc williamfgc self-assigned this Jul 30, 2019
@ax3l
Copy link
Contributor

ax3l commented Jan 30, 2023

We (openPMD -> ECP WarpX / CAAR PIConGPU) are interested in this feature for particle data.

In our simulations, we never need All2All communications. Only I/O requires us to do All2All comms to find global shapes for particles (and their offsets). Since this is a bug fix issue - but more features are needed, I will open another issue to document our request #3452

@pnorbert
Copy link
Contributor Author

This was fixed a long time ago, joined array does work now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants