Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not work with conventional Pull Request commit messages without body #6

Closed
mjhipp opened this issue Sep 3, 2021 · 2 comments
Closed
Assignees
Labels
bug Something isn't working

Comments

@mjhipp
Copy link

mjhipp commented Sep 3, 2021

Describe the bug
Fails to parse conventional commit messages made from squashing and merging Pull Requests if there is no body message.

To Reproduce
Steps to reproduce the behavior:

  1. Squash and merge a pull request (using conventional commits), without adding a body message
  2. Try to create a changelog using extra verbose option
  3. See the TRACE messages and the missing commits from the changelog

Expected behavior
These PR commit messages can be parsed as normal

Screenshots/Logs
I did these steps on a fork of this repo: https://github.com/mjhipp/git-cliff

Created pull requests, and merged them:

Screen Shot 2021-09-02 at 4 52 55 PM

one of them I added an extra message:

Screen Shot 2021-09-02 at 4 49 25 PM

The git log:

Screen Shot 2021-09-02 at 4 55 01 PM

Then tried to create a changelog:

Screen Shot 2021-09-02 at 5 09 07 PM

It is not the parenthesis or #, because it works if I commit directly:

Screen Shot 2021-09-02 at 5 12 11 PM

Screen Shot 2021-09-02 at 5 12 22 PM

If I perform an interactive rebase and "reword" the commits, without actually changing anything, the commits can then be parsed:

Screen Shot 2021-09-02 at 5 15 31 PM
Screen Shot 2021-09-02 at 5 16 28 PM

System (please complete the following information):

  • OS Information: MacOS and ubuntu-latest for git-cliff-action
  • Project Version: 0.1.0 and git-cliff-action@v1

Additional context
Sorry for the long post! This is a great tool and I would really like to be able to use it with squashed PRs!

@mjhipp
Copy link
Author

mjhipp commented Sep 3, 2021

This has already been fixed upstream! https://github.com/crate-ci/git-conventional/releases/tag/v0.10.1

crate-ci/git-conventional#12 (comment)

[dependencies.git-conventional]
version = "0.10.0"
features = ["serde"]

@orhun
Copy link
Owner

orhun commented Sep 4, 2021

Thanks for investigating/reporting this! I'll release a new version to fix this soon.

@orhun orhun closed this as completed in 72cee9c Sep 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants