Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding an OASES model #38

Open
pabloborys opened this issue Sep 27, 2021 · 1 comment
Open

Adding an OASES model #38

pabloborys opened this issue Sep 27, 2021 · 1 comment
Labels
enhancement New feature or request low-priority Low priority issue

Comments

@pabloborys
Copy link

Hi, I understand that adding models is one of the features of UnderwaterAcoustics.jl. I am wondering how hard it would be to add Oases to the available models. Thanks.

@mchitre
Copy link
Member

mchitre commented Sep 27, 2021

I've personally not used OASES much, but shouldn't be that hard. Just need to define an Oases type and implement each of the interface functions for the model:

function check(::Type{Oases}, env)
function arrivals(model::Oases, tx, rx)
function transfercoef(model::Oases, tx, rx)
function eigenrays(model::Oases, tx, rx)
function rays(model::Oases, tx, θ, rmax)

by making equivalent calls in OASES.

@mchitre mchitre added the enhancement New feature or request label Sep 27, 2021
@mchitre mchitre changed the title Adding more models. Adding more models Apr 14, 2022
@mchitre mchitre changed the title Adding more models Adding an OASES model Apr 14, 2022
@mchitre mchitre added the low-priority Low priority issue label Apr 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request low-priority Low priority issue
Projects
None yet
Development

No branches or pull requests

2 participants