Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show sat rarity color on inscription page #1328

Closed
casey opened this issue Jan 22, 2023 · 3 comments · Fixed by #2681
Closed

Show sat rarity color on inscription page #1328

casey opened this issue Jan 22, 2023 · 3 comments · Fixed by #2681

Comments

@casey
Copy link
Collaborator

casey commented Jan 22, 2023

Should the rarity color of a sat be displayed on the inscription's page? Maybe only if it's uncommon or better, so it doesn't feel like a dig on inscribing a common sat.

@batcavekid
Copy link
Contributor

Yes. I think show if rare. Checked all mainnnet inscribed sats today and it was a pain to open a tab for each. Agree don't want throw shade on common sats.

@batcavekid
Copy link
Contributor

batcavekid commented Jan 26, 2023

Do you have a color scheme in mind?

I thought a 6 step grayscale gradient applied to the rarity text and/or an ord logo next to it might look nice.

Thus:
Common (white)
Uncommon
Rare
Epic
Legendary
Mythic (black)

This would make rare sats more obscure and mysterious, and perhaps would not diminish less rare sats as much as would brighter, starkly different colors.

(Omitting the field unless sat is rare feels a bit inconsistent and confusing to me).

@casey
Copy link
Collaborator Author

casey commented Jan 26, 2023

There are actually already rarity colors. Check out the /sat pages for different rarity sats. They're based on classic Diablo/WoW loot colors.

@casey casey linked a pull request Nov 16, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants