Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support arbitrary healthchecks #3

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

support arbitrary healthchecks #3

wants to merge 1 commit into from

Conversation

bassjacob
Copy link

No description provided.

@ordermentum
Copy link

ordermentum bot commented Aug 23, 2019

Please make sure to add screenshots or gifs of the change to give a clear
picture of the change. If a design PR was made please make sure to link to it along with the
JIRA ticket. A Design PR will avoid unnecessary rework that might come up in a PR.

Good Pull Requests adhere to a single responsibility.

  • Break big changes into smaller Pull Requests
  • Big changes increase risk - smaller PRs are easier to review
  • Refactoring changes should be in seperate PRs to avoid noise
  • A story/ticket can have more than 1 PR

Some guidelines on giving and receiving feedback in Code Reviews

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johndagostino johndagostino johndagostino approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bassjacob @johndagostino