FallbackImageDirective and resolve known npm security vulnerabilities

[crhistianramirez]

Description

FallbackImageDirective: this directive will listen to image error event and replace the failed image with a fallback one, I had added it to winmark and thought it might make a good addition here. I had some tests for this but they relied on timeout and were not consistent.

Security Vulnerabilities: npm audit had revealed several known security vulnerabilities that were waiting on this issue to be closed out - karma-runner/karma#2994 after upgrading karma we now have no known security vulnerabilities

Type of change

• New feature (non-breaking change which adds functionality)

Checklist:

• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• I have updated the acceptance criteria on the task so that it can be tested

[oliverheywood451]

Just want to make sure you know || 'http://placehold.it/300x300'" is still in the src attribute. Is that how you want it?

[crhistianramirez]

Yep. the || 'http://placehold.it/300x300'" will take care of the scenario where there is no image defined at all.

My directive will take effect when an image url is defined, but getting that image fails. Possibly the url is simply incorrect. In that case, on fail, itll get replaced by the placeholder url