fix: add address to Pod object

0xmetropolis · Nov 8, 2022 · 9411cbe · 9411cbe
1 parent f2cb046
commit 9411cbe
Show file tree

Hide file tree

Showing 7 changed files with 69 additions and 63 deletions.
diff --git a/docs/assets/search.js b/docs/assets/search.js
diff --git a/docs/classes/Pod.html b/docs/classes/Pod.html
diff --git a/docs/classes/Proposal.html b/docs/classes/Proposal.html
diff --git a/docs/modules.html b/docs/modules.html
diff --git a/scripts/sandbox.ts b/scripts/sandbox.ts
@@ -77,7 +77,7 @@ const multiPodInput = [
 async function main() {
   const { walletOne } = setup(5);
 
-  const pod = await getPod('orca.pod.eth');
+  const pod = await getPod(25);
 
   console.log('pod', pod);
 }

diff --git a/src/Pod.ts b/src/Pod.ts
@@ -118,6 +118,7 @@ export default class Pod {
       this.admin = fetchedAdmin === ethers.constants.AddressZero ? null : fetchedAdmin;
       this.id = podId;
       this.safe = safe;
+      this.address = this.safe;
       this.ensName = Name.name;
 
       const baseUrl = `https://orcaprotocol-nft.vercel.app${
@@ -149,6 +150,9 @@ export default class Pod {
   /** @property Gnosis Safe address */
   safe: string;
 
+  /** @property Gnosis Safe address, duplicate of `safe` */
+  address: string;
+
   /** @property Current nonce, i.e., the nonce of the active proposal */
   nonce: number;
 

diff --git a/test/pod.test.ts b/test/pod.test.ts
@@ -54,6 +54,7 @@ test('getPod should be able to fetch via address', async () => {
   const pod = await getPod(orcanautAddress);
   expect(pod.id).toEqual(orcanautPod.id);
   expect(pod.safe).toEqual(orcanautPod.safe);
+  expect(pod.address).toEqual(pod.safe);
   expect(pod.imageNoTextUrl).toEqual(orcanautPod.imageNoTextUrl);
   expect(pod.admin).toEqual(orcanautPod.admin);
   expect(pod.ensName).toEqual(orcanautPod.ensName);