Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Golang 1.9 and concurrent map #60

Closed
matcornic opened this issue Sep 4, 2017 · 4 comments
Closed

Golang 1.9 and concurrent map #60

matcornic opened this issue Sep 4, 2017 · 4 comments

Comments

@matcornic
Copy link

Hello,

Thanks for this package that has been useful for years.
Golang 1.9 now provides a concurrent map in standard library. Consider mentioning it on the README for those using latest version of Golang.

Though, the package is still very useful for older versions :)

@orcaman
Copy link
Owner

orcaman commented Sep 4, 2017

@matcornic thanks for the feedback, we're glad that you found this useful!

As for the 1.9 sync.Map - it has a few key differences from this map. The stdlib sync.Map is designed for append-only scenarios. So if you want to use the map for something more like in-memory db, you might benefit from using our version. You can read more about it in the golang repo, for example here: golang/go#21035 (comment) and here: https://stackoverflow.com/questions/11063473/map-with-concurrent-access

@matcornic
Copy link
Author

matcornic commented Sep 4, 2017

@orcaman thanks for your quick answer ! Your explanation makes sense. So, in my opinion, differences between your package and standard library are worth explaining in the README.
We should be clear on which situation your library is more suited than the standard library, and in which cases it's not 👍

@orcaman
Copy link
Owner

orcaman commented Sep 4, 2017

Good point. I will update the README.md

@orcaman
Copy link
Owner

orcaman commented Oct 24, 2017

Merged as per our discussion. Thanks!

@orcaman orcaman closed this as completed Oct 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants