-
-
Notifications
You must be signed in to change notification settings - Fork 571
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TodoMVC example #246
Comments
Updated https://github.com/haadcode/example-orbitdb-todomvc and added a live demo |
Open the live demo in a second browser (or in incognito window) and you should have them both updating the TODO list: |
Need to update the code ^ to work with the latest releases of orbitdb and ipfs before this is finished. |
Hello, can I work on this issue? |
@natachadelarosa absolutely! Would love to get the example updated! 😄❤️ I believe what needs to be done, is to:
I believe those are all changes that are needed but there may be more small things that don't work (the code hasn't been updated in a while). Let us know if you hit any problems or have any questions! |
Hello, Sorry for the delay in this, I had a rough week. Could it be a problem if I do the project from 0? Because most of the package that uses are deprecated also de project organization is a bit outdated. Regards, |
@natachadelarosa no problem at all to do it from scratch! Happy to replace the earlier project and help with any questions or review code if you want. |
Hello @haadcode sorry for the delay on this, I didn't have the time, have had too much on my hands with Consensys dev program and my work. Yesterday I began to work on it and it's ready, on this link you can check it out and do a code review: https://github.com/natachadelarosa/example-orbitdb-todomvc-updated Sorry again for the delay. Best regards, |
Also, there's a couple of changes, as I told you before, I changed the entire structure of the project. This is what I did:
And I tried to follow ES6 as much as I could. |
This is awesome! So cool to see this work. 🎉 👍 👍 🌟 |
Thanks for your kind words @RichardLitt 👍 |
@natachadelarosa sorry it took a while to get back to you! First, thank you for coming back to this and re-writing the example! 👍❤️ The code looks good to me and there are no glaring problems that I can see. There are some smaller things where the code could be improved, but I don't feel they're blockers to call it ready :) Would you want to move the repo to the @orbitdb organization? We could also just have it where it is atm and add it to the README and other relevant docs. Are you interested to maintain the project in the future? (You can totally say no, too! :)) |
Hi, I'm just testing Orbitdb around here. It seems to work ok with two separate browsers, but if I open it in two separate tabs, the consistency goes haywire. Is that a known limitation (from IndexedDB?) |
More or less. Essentially the tabs share the same IPFS browser node (same IPFS id) and are going to conflict. |
Concurrent tab support has been added! Closing this. |
I made an example on how to use OrbitDB with TodoMVC:
https://github.com/haadcode/example-orbitdb-todomvc.
We should add it to the readme.
The text was updated successfully, but these errors were encountered: