Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TodoMVC example #246

Closed
haadcode opened this issue Nov 15, 2017 · 17 comments
Closed

TodoMVC example #246

haadcode opened this issue Nov 15, 2017 · 17 comments

Comments

@haadcode
Copy link
Member

I made an example on how to use OrbitDB with TodoMVC:
https://github.com/haadcode/example-orbitdb-todomvc.

We should add it to the readme.

@haadcode
Copy link
Member Author

@haadcode
Copy link
Member Author

Open the live demo in a second browser (or in incognito window) and you should have them both updating the TODO list:

@haadcode
Copy link
Member Author

Need to update the code ^ to work with the latest releases of orbitdb and ipfs before this is finished.

@dnoishi
Copy link
Member

dnoishi commented Jun 1, 2018

Hello, can I work on this issue?

@haadcode
Copy link
Member Author

haadcode commented Jun 3, 2018

@natachadelarosa absolutely! Would love to get the example updated! 😄❤️

I believe what needs to be done, is to:

I believe those are all changes that are needed but there may be more small things that don't work (the code hasn't been updated in a while). Let us know if you hit any problems or have any questions!

@dnoishi
Copy link
Member

dnoishi commented Jun 8, 2018

Hello,

Sorry for the delay in this, I had a rough week.

Could it be a problem if I do the project from 0? Because most of the package that uses are deprecated also de project organization is a bit outdated.

Regards,

@haadcode
Copy link
Member Author

haadcode commented Jun 8, 2018

@natachadelarosa no problem at all to do it from scratch! Happy to replace the earlier project and help with any questions or review code if you want.

@dnoishi
Copy link
Member

dnoishi commented Sep 9, 2018

Hello @haadcode sorry for the delay on this, I didn't have the time, have had too much on my hands with Consensys dev program and my work. Yesterday I began to work on it and it's ready, on this link you can check it out and do a code review: https://github.com/natachadelarosa/example-orbitdb-todomvc-updated

Sorry again for the delay.

Best regards,

@dnoishi
Copy link
Member

dnoishi commented Sep 9, 2018

Also, there's a couple of changes, as I told you before, I changed the entire structure of the project.

This is what I did:

  • create-react-app as the base project
  • todomvc-app-css for the style
  • react-router instead of director for the navigation, this because director package was giving me problems with Webpack.

And I tried to follow ES6 as much as I could.

@RichardLitt
Copy link
Member

This is awesome! So cool to see this work. 🎉 👍 👍 🌟

@dnoishi
Copy link
Member

dnoishi commented Sep 10, 2018

Thanks for your kind words @RichardLitt 👍

@haadcode
Copy link
Member Author

@natachadelarosa sorry it took a while to get back to you! First, thank you for coming back to this and re-writing the example! 👍❤️

The code looks good to me and there are no glaring problems that I can see. There are some smaller things where the code could be improved, but I don't feel they're blockers to call it ready :)

Would you want to move the repo to the @orbitdb organization? We could also just have it where it is atm and add it to the README and other relevant docs. Are you interested to maintain the project in the future? (You can totally say no, too! :))

@dnoishi
Copy link
Member

dnoishi commented Sep 26, 2018

Hi @haadcode!

How can I move the repo to the @orbitdb organization? Do I need to make a push request to the original repo?

And of course I'll be happy to maintain the project and also help with other issues as well, I want to help as much as I can!

@RichardLitt
Copy link
Member

I've invited you to the @orbitdb org. :) Use your powers (you can see other members, create repos, and teams) for good.

When you've accepted, you'll be able to move the repo over to @orbitdb. :D

@sundbry
Copy link

sundbry commented Jan 17, 2019

Hi, I'm just testing Orbitdb around here. It seems to work ok with two separate browsers, but if I open it in two separate tabs, the consistency goes haywire. Is that a known limitation (from IndexedDB?)

@aphelionz
Copy link
Member

More or less. Essentially the tabs share the same IPFS browser node (same IPFS id) and are going to conflict.

@aphelionz
Copy link
Member

Concurrent tab support has been added! Closing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants