Skip to content
This repository has been archived by the owner on Sep 30, 2023. It is now read-only.

add sig cache #38

Merged
merged 4 commits into from
Nov 25, 2019
Merged

add sig cache #38

merged 4 commits into from
Nov 25, 2019

Conversation

shamb0t
Copy link
Contributor

@shamb0t shamb0t commented Sep 27, 2019

Adds cache for known signatures

@aphelionz
Copy link
Contributor

This looks good to me, nice catch with the v0 signatures too.

I'm wondering if you can try using the hrtime method I did here in my first attempt in the tests to see what kind of perf improvement we get?

@aphelionz
Copy link
Contributor

Eschewing the hrtime request, just having tests at all would be great. I'd be happy to write them if you'd like.

@aphelionz
Copy link
Contributor

LGTM!

@shamb0t shamb0t merged commit 409d6d4 into master Nov 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants