add knownIdentities cache #53
Conversation
| return false | ||
| } | ||
|
|
||
| const verifyIdSig = await Keystore.verify( |
There was a problem hiding this comment.
Which Keystore instance (or data directory) does this use?
There was a problem hiding this comment.
@haadcode it uses the Keystore's static verify method, it doesn't use a directory https://github.com/orbitdb/orbit-db-keystore/blob/409d6d46f1260c2a00ae2920a068460a2298481c/src/keystore.js#L182
There was a problem hiding this comment.
Thanks @shamb0t, makes sense 👍
There was a problem hiding this comment.
@haadcode hmm after running tests with orbit-db its true that if a custom keystore is used then the custom keystore should also be used for verifying. Does it make sense to have the static verifyIdentity only verify identities which used orbit-db-keystore? (ie this._keystore.verify in the non-static method and Keystore.verify in the static method)
There was a problem hiding this comment.
You're right, perhaps we don't need the static method. I'd keep it in though in this PR and remove it later on. For now, we should be good, right?
|
LGTM @shamb0t 👍 |
Adds cache for known identities