This repository has been archived by the owner on Sep 30, 2023. It is now read-only.
Optimize loading #275
Merged
Optimize loading #275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shamb0t
force-pushed
the
feat/load-opt
branch
from
42b521f to
e4a2bd6
Compare
shamb0t
force-pushed
the
feat/load-opt
branch
from
5b49be1 to
a742011
Compare
add tests
Fix tests Clean up code Improve loading visualization Increase browser tests timeout Use await in entry-io
shamb0t
force-pushed
the
feat/load-opt
branch
from
536f747 to
5d31278
Compare
5 tasks
|
Depends on #278. |
More backwards compatibility tests
haadcode
reviewed
Nov 20, 2019
shamb0t
commented
Nov 20, 2019
haadcode
force-pushed
the
feat/load-opt
branch
from
d99b7f4 to
fedad84
Compare
haadcode
force-pushed
the
feat/load-opt
branch
from
fedad84 to
ae8e5c0
Compare
added 2 commits
November 20, 2019 13:33
shamb0t
force-pushed
the
feat/load-opt
branch
from
859742d to
d26a4ac
Compare
|
LGTM now 👍 I believe this would be ready to merge. |
|
Added one fix that I spotted going through the code. |
add pin option
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds references powers of 2 apart to Entry to improve fetching performance