Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Description of non-opensource private filters #30

Open
xlz opened this issue Dec 13, 2024 · 2 comments
Open

Description of non-opensource private filters #30

xlz opened this issue Dec 13, 2024 · 2 comments

Comments

@xlz
Copy link

xlz commented Dec 13, 2024

https://github.com/orbbec/OrbbecSDK_v2/tree/main/extensions

filters/linux_x86_64/libFilterProcessor.so
filters/linux_x86_64/libob_priv_filter.so
frameprocessor/linux_x86_64/libob_frame_processor.so

Why are these libraries not open source?

Can you provide a description of the list of functionalities that these libraries provide, so these closed source libraries can be replaced with open source implementations with community improvements?

From objdump I'm seeing:

filters/linux_x86_64/libFilterProcessor.so:
- depth_api_hole_filling_filter
- depth_api_horizontal_margin_filter
- depth_api_margin_filter
- depth_api_spatial_filter
- depth_api_temporal_filter

filters/linux_x86_64/libob_priv_filter.so:
- G2XL (Gemini 2 XL?) depth correction and decompress
- RVL/MT RVL/TC RVL/MTTC RVL compression: what is MT, TC, MTTC? 

frameprocessor/linux_x86_64/libob_frame_processor.so
- HardwareD2CProcessor: hardware depth to color alignment?

RVL compression seems to be useful for streaming depth images, but there is existing open source implementations https://github.com/catid/Zdepth, so it wouldn't be necessary to close source this.

I wouldn't care for open sourcing the firmware updater as it is highly hardware dependent. But the rest of these libraries seem to be standard image processing routines and there is huge room for community improvements, e.g. I can do many of these things faster with CUDA.

So, is it necessary to close source these?

@zhonghong322
Copy link
Contributor

Due to business considerations, it will not be open-sourced for the time being

@xlz
Copy link
Author

xlz commented Dec 23, 2024

Then this repo is not open source as advertised.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants