Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move common options to a common file #385

Closed
qweeah opened this issue May 16, 2022 · 0 comments · Fixed by #386
Closed

Move common options to a common file #385

qweeah opened this issue May 16, 2022 · 0 comments · Fixed by #386
Assignees
@qweeah
Milestone
v0.13.0

Comments

@qweeah
Copy link
Contributor

qweeah commented May 16, 2022 •
edited
Loading

Some options are duplicated for all the command line operations like oras login/pull/push/copy/discover. Could we refactor it to commonOptions in common.go?

Originally posted by @shizhMSFT in #380 (comment)
@qweeah qweeah changed the title Move common CMD options to a common file Move common options to a common file May 16, 2022
@qweeah qweeah mentioned this issue May 16, 2022
Merged
@shizhMSFT shizhMSFT added this to the v0.13.0 milestone May 16, 2022
@qweeah qweeah mentioned this issue May 16, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@qweeah qweeah

Labels
None yet
Projects
None yet
Milestone
v0.13.0
Development

Successfully merging a pull request may close this issue.

Move reusable options to a dedicated package qweeah/oras
2 participants
@qweeah @shizhMSFT